Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from 'query' to 'stream' terminology #126

Closed
rib opened this issue Mar 2, 2016 · 1 comment
Closed

switch from 'query' to 'stream' terminology #126

rib opened this issue Mar 2, 2016 · 1 comment
Assignees

Comments

@rib
Copy link
Owner

rib commented Mar 2, 2016

We have lots of things using the term 'query' which is a hangover from code for working with the GL_INTEL_performance_query extension. In that case a query represents a delimited query for metrics made via the command stream whereas mostly all other metrics are periodically sampled and read from the kernel as a stream.

At some point we should get rid of this naming confusion.

In the case of struct gputop_perf_query this represents the (mostly immutable) meta data for a metric set, automatically generated from the XML data by oa-gen.py. probably struct gputop_metric_set would be a better description.

struct gputop_worker_query has an extra naming hangover from when the code used to be run in a Web Worker thread which isn't true anymore. This one should probably become a 'stream' something like struct gputop_remote_stream

@rib
Copy link
Owner Author

rib commented Mar 15, 2016

Changed in 6979e0a

@rib rib closed this as completed Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant