Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The files generated for drm/i915 have incorrect SPDX header comment style #197

Closed
jnikula opened this issue Feb 5, 2019 · 2 comments
Closed

Comments

@jnikula
Copy link
Contributor

jnikula commented Feb 5, 2019

All the files are prefixed with:

/*
* SPDX-License-Identifier: MIT
*

while the correct format for C source files is:

// SPDX-License-Identifier: MIT

and C header files:

/* SPDX-License-Identifier: MIT */

See https://www.kernel.org/doc/html/latest/process/license-rules.html

@djdeath
Copy link
Collaborator

djdeath commented Mar 11, 2019

I would like to retain the autogenerated warning in those files.
What should the format look like in that case?

@jnikula
Copy link
Contributor Author

jnikula commented Mar 11, 2019

Add a free form comment after the single line SPDX header that has format requirements. (N.b. I didn't make these up, I wouldn't have used // but I don't want to start deviating either.)

C source:

// SPDX-License-Identifier: MIT
/*
 * Copyright © 2018 Intel Corporation
 *
 * Autogenerated file by GPU Top : https://github.com/rib/gputop
 * DO NOT EDIT manually!
 */

C header:

/* SPDX-License-Identifier: MIT */
/*
 * Copyright © 2018 Intel Corporation
 *
 * Autogenerated file by GPU Top : https://github.com/rib/gputop
 * DO NOT EDIT manually!
 */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants