Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out shared OA counter accumulation code #22

Closed
rib opened this issue Nov 26, 2015 · 1 comment
Closed

Factor out shared OA counter accumulation code #22

rib opened this issue Nov 26, 2015 · 1 comment
Assignees
@Kasi-Reddy

Comments

@rib
Copy link
Owner

rib commented Nov 26, 2015

gputop_perf_accumulate() in gputop-perf.c is the same as accumulate_oa_reports() in gputop-web-worker.c. accumulate_uint32() and accumulate_uint40() have also been copied.

We can add a gputop/gputop-oa-counters.c and gputop/gputop-oa-counters.h with this common code named something like gputop_oa_accumulate_reports() and gputop/Makefile.am and gputop/web/Makefile.emscripten can both be updated to build the same code instead.
@rib rib mentioned this issue Nov 26, 2015
Closed
@Kasi-Reddy Kasi-Reddy self-assigned this Nov 30, 2015
@rib rib mentioned this issue Dec 1, 2015
Merged
@rib
Copy link
Owner Author

rib commented Dec 1, 2015

Resolved in #28

@rib rib closed this as completed Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kasi-Reddy Kasi-Reddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rib @Kasi-Reddy