Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test certs expired in March #27

Closed
CowEther opened this issue May 18, 2020 · 2 comments
Closed

Test certs expired in March #27

CowEther opened this issue May 18, 2020 · 2 comments

Comments

@CowEther
Copy link

Builds are failing because the hard-coded client and server test certs have expired. The test certs need to be regenerated (or possibly find a way to create the at test runtime).

Steps to reproduce:

  1. Checkout master
  2. Run make or docker build

Actual Behavior:
GO111MODULE=on go test -race -mod=vendor ./... 2020/05/18 16:15:03 http: TLS handshake error from 127.0.0.1:61858: remote error: tls: bad certificate time="2020-05-18T16:15:03-04:00" level=error msg="Get \"https://127.0.0.1:61857\": x509: certificate has expired or is not yet valid: current time 2020-05-18T16:15:03-04:00 is after 2020-03-28T07:52:27Z" source="ssl_exporter.go:108"

Expected Behavior:
Certs expected to not be expired are not expired, tests pass successfully.

@ribbybibby
Copy link
Owner

Thank you for bringing this to my attention @CowEther! It was certainly very short sighted on my part not to at least set a reminder for this..

I've renewed the certificates and given them a much longer validity period (10 years): 1305aac. I've also set a reminder for my future self.

As you mentioned, it might be better to generate these certs at runtime. I'll have a quick look at the best way to achieve that.

@ribbybibby
Copy link
Owner

Certificates are now generated for tests on the fly as of #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants