Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between Digicert::DuplicateCertificate.all and order.duplicate_certificates #141

Closed
kwkwan opened this issue Apr 18, 2018 · 1 comment · Fixed by #143
Closed
Assignees

Comments

@kwkwan
Copy link
Contributor

kwkwan commented Apr 18, 2018

This works:

    dup_certificates = Digicert::DuplicateCertificate.all(
      order_id: order_id,
      sort: 'date_created',
      limit: 1,
      offset: 0,
    )

But this doesn't:

    dup_certificates = order.duplicate_certificates(
      sort: 'date_created',
      limit: 1,
      offset: 0,
    )

It'll be great if both work the same way. Thanks!

@abunashir
Copy link
Member

Thanks for reporting this @kwkwan, I just added the support for the option in the attached pull request, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants