Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache support #10

Closed
ricardofiorani opened this issue Jul 28, 2018 · 3 comments
Closed

Add cache support #10

ricardofiorani opened this issue Jul 28, 2018 · 3 comments
Labels
enhancement help wanted

Comments

@ricardofiorani
Copy link
Owner

Today, in VideoServiceMatcher::parse() we have a logic that saves in an array URLs that were already parsed, however it persists within the same request only.
We need to add cache support to save the already parsed.

It must be implemented following PSR-6.
@renanbr
Copy link

renanbr commented Aug 31, 2018

Is there any particular reason you prefer PSR-6 over PSR-16?

@ricardofiorani
Copy link
Owner Author

No. When I wrote this issue it was more as a reminder, the implementation can follow PSR-16.

@renanbr renanbr mentioned this issue Sep 1, 2018
Merged
@ricardofiorani
Copy link
Owner Author

@renanbr thank you for you contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@renanbr @ricardofiorani