-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.11 open(path,"U") -->invalid mode. #58
Comments
Looking at the doc. https://docs.python.org/3/library/functions.html#open The default open mode is already text mode or we can use as below?
|
Just dropping the mode should be enough. Thanks for reporting of this regression. |
created pull request for the same |
I can confirm that this fixes this issue for me. |
Not being able to see the diff in the changes section on python 3.11 due to "U" mode being deprecated on python 3.11
File "/usr/lib/python3.11/site-packages/snappergui/changesWindow.py", line 165, in get_lines_from_file return open(path, 'U').readlines() ^^^^^^^^^^^^^^^ ValueError: invalid mode: 'U'
From python docs:
https://docs.python.org/3/whatsnew/3.11.html#porting-to-python-3-11
The text was updated successfully, but these errors were encountered: