Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Avoid using mocks in the tests #64

Closed
r-darwish opened this issue Jan 13, 2016 · 1 comment
Closed

Avoid using mocks in the tests #64

r-darwish opened this issue Jan 13, 2016 · 1 comment

Comments

@r-darwish
Copy link
Collaborator

Most of our tests use mocks instead of contacting the real Pushbullet. As I said in #63, I don't think that it's such a good idea because our tests will pass even if Pushbullet change the API. As stated in #57, the "contacts" API has been obsolete for a while and our tests didn't detect that breakage.

@kovacsbalu
Copy link
Collaborator

Hi @r-darwish,
in my view these tests are unit test and as I understand you need integration tests. So, feel free to write some.

@rbrcsk rbrcsk closed this as completed Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants