-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vticker has no 'destroy' or 'remove' method #10
Comments
Just realised that the view ends up being removed before the close function gets called so the plugin isn't properly cleaned up, so I fixed the error on my end by calling the stop method. However it would still be nice to be able to remove the plugin from an element in any case. |
Hi @ben-eb - so just one method call to remove and unbind? Is that essentially what were talking about here? |
Essentially, yes; I'd expect such a method call to return the element to the state it was in before
|
Ok, sounds like a good idea. I'll look at adding. |
v1.14 adds remove method. |
Great, thank you for resolving it so quickly. 👍 |
I'd like to be able to remove an element from the DOM that has an instance of vticker attached to it when my view updates. If I do something like this:
When the
close
method is called I get this type error every time the interval is called:Even if I call the 'stop' method that still ends up firing this error. What I would like to be able to do is to completely remove vticker from the element. Are there any plans to add this feature?
The text was updated successfully, but these errors were encountered: