Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration path #27

Merged
merged 16 commits into from
Jan 28, 2023
Merged

Configuration path #27

merged 16 commits into from
Jan 28, 2023

Conversation

richibrics
Copy link
Owner

@richibrics richibrics commented Dec 15, 2022 •
edited
Loading

  • Copy from old folder to new one
  • Env var IOTURING_CONFIG_DIR

@richibrics richibrics linked an issue Dec 15, 2022 that may be closed by this pull request
Configuration file needs a new location #16
Closed
@richibrics richibrics marked this pull request as ready for review December 23, 2022 15:21
infeeeee
infeeeee reviewed Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@infeeeee infeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I commented too much, some of them are just semantics, sorry :)

IoTuring/Configurator/Configurator.py Show resolved Hide resolved
IoTuring/Configurator/ConfiguratorIO.py Outdated Show resolved Hide resolved
IoTuring/Configurator/ConfiguratorIO.py Show resolved Hide resolved
IoTuring/Configurator/Configurator.py Outdated Show resolved Hide resolved
IoTuring/Configurator/Configurator.py Outdated Show resolved Hide resolved
IoTuring/Configurator/ConfiguratorIO.py Outdated Show resolved Hide resolved
IoTuring/Configurator/ConfiguratorIO.py Outdated Show resolved Hide resolved
IoTuring/__init__.py Outdated Show resolved Hide resolved
IoTuring/Configurator/ConfiguratorIO.py Outdated Show resolved Hide resolved
richibrics and others added 7 commits January 24, 2023 13:29
@richibrics @infeeeee
Update IoTuring/Configurator/ConfiguratorIO.py
8b25533 
Co-authored-by: infeeeee <gyetpet@mailbox.org>
@richibrics @infeeeee
Update IoTuring/Configurator/Configurator.py
c6a6449 
Co-authored-by: infeeeee <gyetpet@mailbox.org>
@richibrics @infeeeee
Semantic improvement
7f0c49d 
Co-authored-by: infeeeee <gyetpet@mailbox.org>
@richibrics @infeeeee
Semantic improvement
50da803 
Co-authored-by: infeeeee <gyetpet@mailbox.org>
@richibrics @infeeeee
Semantic improvement
bec3efa 
Co-authored-by: infeeeee <gyetpet@mailbox.org>
@richibrics
Semantic improvement
b0ea893
@richibrics
fix create folder to move existing file
e860139
richibrics
richibrics commented Jan 24, 2023
View reviewed changes
Copy link
Owner Author

@richibrics richibrics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all @infeeeee comments

@richibrics richibrics mentioned this pull request Jan 24, 2023
Merged
@richibrics
Copy link
Owner Author

richibrics commented Jan 28, 2023 •
edited
Loading

This is mergeable, isn't it ? @infeeeee

infeeeee
infeeeee reviewed Jan 28, 2023
View reviewed changes
Copy link
Collaborator

@infeeeee infeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a small grammatical error, otherwise LGTM!

@richibrics
Copy link
Owner Author

Yes, correct !

@richibrics richibrics merged commit 64912b5 into main Jan 28, 2023
@richibrics richibrics deleted the configuration-path branch January 28, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infeeeee infeeeee infeeeee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration file needs a new location
2 participants
@richibrics @infeeeee