Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isoNo returns non-standardized format #38

Open
nycodinguru opened this issue Apr 5, 2023 · 1 comment
Open

isoNo returns non-standardized format #38

nycodinguru opened this issue Apr 5, 2023 · 1 comment

Comments

@nycodinguru
Copy link

Running the isoNo method can return a single or two character string. For example, looking up Afghanistan's ISO numeric-3 country code returns '4' instead of '004'. This can be fixed by enforcing string length of 3 for isoNo values and adding leading zeros as padding using JS's padStart method. I'd be happy to help you implement this if you want some assistance. 🙂

@richorama
Copy link
Owner

yes, I agree, they should be 3 digits with a padding of zeros. I would prefer to fix in the source data if possible. Which is something I'll look at later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants