Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming issues in next version of web UI 1.6.0, Gradio 3.39 #88

Closed
w-e-w opened this issue Aug 5, 2023 · 7 comments
Closed

Upcoming issues in next version of web UI 1.6.0, Gradio 3.39 #88

w-e-w opened this issue Aug 5, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@w-e-w
Copy link

w-e-w commented Aug 5, 2023

in the next version of web UI we are moving to Gradio 3.39, see current dev branch

with this comes a new feature, the inpaint mask is render as transparent

this is from the sketch tool not colore-sketch tool

this main issue is that this extension injects some code into Gradio lib, which causes the transparency to not work

some other things is also displayed weirdly

furthermore the change is injectded itself into Gradio and so the changes persist even after the extension is disabled or removed

@w-e-w w-e-w changed the title Upcoming issues in next version of web UI, Gradio 3.39 Upcoming issues in next version of web UI 1.6.0, Gradio 3.39 Aug 5, 2023
@daswer123
Copy link
Collaborator

Yes, I will look into porting all canvas-zoom modifications to the new version of gradio so that there are no problems with the new webui version.

Thanks for letting me know.

@daswer123
Copy link
Collaborator

furthermore the change is injectded itself into Gradio and so the changes persist even after the extension is disabled or removed

There is definitely a problem with this, as there is no procedure for uninstalling the extension to properly restore the gradio library.

https://github.com/richrobber2/canvas-zoom/wiki/Troubleshooting#i-deleted-the-extension-but-some-elements-of-the-extension-remain

@daswer123
Copy link
Collaborator

@w-e-w
I have an idea how this could be fixed, do you think this solution would be a good one?

Actually I have an idea, for example, when installing canvas-zoom, I put a file detect_canvas_zoom.py in the scripts folder, which will check whether the extension is installed or not, if the user deleted the extension folder, then this script at the next startup, automatically reinstall gradio and self-delete.

@w-e-w
Copy link
Author

w-e-w commented Aug 5, 2023

well we kind of arrived at the same solution
but when I brought the idea up with auto he doesn't seem to keen
either that or my initial picture of the idea was not that great

I think it may be better for you to join auto's discord so you can discuss with him directly?

then invite link is on the web UI contribution page in the wiki

I'm not in front of my computer right now

@w-e-w
Copy link
Author

w-e-w commented Aug 5, 2023

is patching the lib absolutely necessary no way around it?

@daswer123
Copy link
Collaborator

daswer123 commented Aug 5, 2023

is patching the lib absolutely necessary no way around it?

The modified library contains a lot of small changes that cannot be done from the outside.

I moved everything that worked well to the build in extension, because all other functionality in one way or another relies on modification of gradio.

I don't change anything coordinate, in many respects the extension relies on these small functions that ensure correct work, in fact the same gradio but with a small modification.

then invite link is on the web UI contribution page in the wiki

I'm already in your community :) , you can tag me in discord @daswer123.

@daswer123
Copy link
Collaborator

daswer123 commented Aug 5, 2023

@w-e-w
Updated to version 3.39, and also added detection for the presence of an extension, and if it is not present, gradio is reinstalled.

The installation method is so far, old, I need to figure out how to swap the folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants