Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity in <plug> mapping's name #5

Closed
kminh opened this issue Nov 15, 2015 · 1 comment
Closed

Ambiguity in <plug> mapping's name #5

kminh opened this issue Nov 15, 2015 · 1 comment

Comments

@kminh
Copy link

kminh commented Nov 15, 2015

Hello and thank you for this plugin.

Not sure if it's just me, but when I try visually selecting anything and press cy Vim doesn't copy the selected text right away (I need to press something else). This has something to do with the ambiguity of the mapping's name. When I make the following change it works as expected:

vnoremap <silent> <Plug>EclipticVY_v    :call <SID>EclipticCopy(visualmode())<cr>
vnoremap <silent> <Plug>EclipticVY_V    :call <SID>EclipticCopy('V')<cr> # I think it makes sense to change this to _V too

This applies to visual deletion as well.

Btw, there's an echo "here" debug code that's lying around in your code.

@richsoni
Copy link
Owner

@kminh sorry for the really long delay. I never got a notification for this.

This works makes sense, and I looked at your code. If you make a pull request, I would love to merge in your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants