Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Selection / Section by Required / Recommended #9

Closed
meshakeeb opened this issue Aug 21, 2017 · 18 comments
Closed

Plugin Selection / Section by Required / Recommended #9

meshakeeb opened this issue Aug 21, 2017 · 18 comments

Comments

@meshakeeb
Copy link

Hi,

I have couple of required plugin and rest of them are recommended plugins. But Merlin is installing them all in my opinion.

There should be headings for required and recommended plugins and also selection for what plugins we want to install.

Thanks

@richtabor
Copy link
Owner

Good idea! Maybe something like how the content importer works, where you check each one on or off. 👍

@meshakeeb
Copy link
Author

@richtabor the PR is ready for your review.

@contempoinc
Copy link

Any updates on this one?

@capuderg
Copy link
Collaborator

We have it on the todo list, but I can't give you any specific dates as to when this will be added.

@capuderg
Copy link
Collaborator

Hi,

I've just pushed the functionality for selectable plugins in this branch: add-plugin-selection.

The plugin list is now split into two sections (required and recommended plugins) and the user can select which plugins to install. Currently it looks like this:
merlinwp-selectable-plugins

I would really like to get some feedback from you @richtabor (functionality and UX/design), so I know, if it's good enough, so we can then merge it and create a new release for others to test it out.

@richtabor
Copy link
Owner

Hey @capuderg, instead of splitting them out, what do you think about using a badge to signify the required plugins?

Like this:

screen shot 2018-04-10 at 9 37 25 am

My thoughts:

  1. By using a badge to signify required plugins, if there are no "required" plugins, there is no difference in the UI.
  2. Plugins that are listed are obviously recommended (as they are included here in the first place) so we don't need to state that recommend.
  3. The less UI, the better (especially for a first-touch experience like wizards).

What do you think?

@contempoinc
Copy link

contempoinc commented Apr 10, 2018 via email

@contempoinc
Copy link

contempoinc commented Apr 10, 2018 via email

@richtabor
Copy link
Owner

I'd say all of the plugins should be de-selectable — even "required" plugins.

@richtabor
Copy link
Owner

The idea behind the word "Advanced" there, is that turning on/off plugins is an advanced setting, apart from what the theme developer selected as a default setup. Does that make sense?

I don't know what else would convey that properly, maybe "Select Plugins". 🤔

@contempoinc
Copy link

contempoinc commented Apr 10, 2018

@richtabor If you make the required plugins deselectable from my experience it ends up in more support because people literally don't get it, that they're 100% required for the theme to work. So they'll deselect it maybe on purpose or by sheer ignorance and then hit me up with "Why isn't this working, blah, blah, blah?", etc…

I do get what you're saying about the "Advanced", but I like "Select Plugins" think that works well.

@richtabor
Copy link
Owner

@contempoinc I see your point, but I still think the decision should ultimately be up to the user of the theme and that it shouldn't be forced upon them.

@capuderg
Copy link
Collaborator

I agree with @richtabor on the plugin selection. The final decision should be up to the user.

As for not splitting them into two categories -> I see your point of "recommended" being unnecessary and I like the badge idea, but I'm not sure "req" will be enough for a WP newbie to know, what it means. Having the full word "required" in the badge, might be to much.

@richtabor
Copy link
Owner

@capuderg Maybe make it also have a tooltip, if the user were to hover over it? It could say "Required Plugin", or something. I agree - the word "required" may not fit right, unless it was even smaller than it currently is.

Would you be able to remove the split functionality and implement the badge? Then I could go in and explore the UI with the badge to see what works best in real time.

@capuderg
Copy link
Collaborator

@richtabor yeah sure. I'll try to push this change in a few minutes.

@capuderg
Copy link
Collaborator

@richtabor I've pushed the changes, but they were very little ones. I've just removed the titles and added the "req" badge (span with a class).

I still left the ordering of required plugins on top of the list. But if that is something we don't need, I can remove that as well.

@richtabor
Copy link
Owner

Thanks @capuderg. I like that the required plugins will be positioned at the top. 👍

@contempoinc
Copy link

Looking forward to this update!

richtabor pushed a commit that referenced this issue Apr 16, 2018
Add Plugin Selection + REQ badge (with tooltip) as per #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants