Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Bug: Let findFeatures functions also accept files which have lowercase file extension #43

Closed
hechth opened this issue Jan 31, 2022 · 1 comment

Comments

@hechth
Copy link

hechth commented Jan 31, 2022

Similar to when importing the files into the info, the findFeatures functions don't accept lowercase filenames etc. which have an .mzml extension.

> info <- patRoon::generateAnalysisInfo("myvolume")
> features <- patRoon::findFeaturesXCMS3(info)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201001_003-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201001_098-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201009_003-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201009_098-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201016_003-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201016_098-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201021_003-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201021_098-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201202_003-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201202_098-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201209_003-QCstd_POS_MU.mzml] (in myvolume)
Analysis does not exist: Galaxy23-[qc_solvent_centroids__Tribrid_201209_090-QCstd_POS_MU.mzml] (in myvolume)
Error in patRoon::findFeaturesXCMS3(info) : 1 assertions failed:
 * Variable 'x': No analyses found with correct data format (valid: mzXML, mzML).
@rickhelmus
Copy link
Owner

Alright, the needed code changes for correct case insensitive file extension checking was quite more involving than expected. The commit linked above should handle all cases throughout the workflow now.

@hechth hechth closed this as completed Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants