New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split asserts into distinct errors #7

Closed

nmushegian opened this issue Jul 11, 2022 · 1 comment

Contributor

nmushegian commented Jul 11, 2022

multisig/src/Multisig.vy

Lines 33 to 35 in ffb598d

    
           assert len(members) <= MAX_OWNERS\ 
        
              and len(members) >= threshold\ 
        
              and threshold > 0, 'Config err'

multisig/src/Multisig.vy

Lines 59 to 61 in ffb598d

    
           assert len(v) == len(r)\ 
        
              and len(r) == len(s)\ 
        
              and len(s) == self.threshold, 'Num sigs err'

Contributor Author

nmushegian commented Jul 11, 2022

2nd one makes sense to keep as one condition I guess, 1st one fixed

nmushegian closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment