Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css-loader e.charCodeAt is not a function #77

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

ricokahler
Copy link
Owner

@ricokahler ricokahler commented Dec 11, 2021

The next/babel preset utilizes an isServer check to conditionally remove the certain loaders that are only compatible with the browser. This adds that check in the preval loader case and should fix #66

@ricokahler ricokahler changed the base branch from main to alpha December 11, 2021 18:32
@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #77 (3b5b2fe) into alpha (3e7cef2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            alpha      #77   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files           2        2           
  Lines          96       96           
  Branches       32       32           
=======================================
  Hits           89       89           
  Misses          6        6           
  Partials        1        1           
Impacted Files Coverage Δ
src/loader.ts 94.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7cef2...3b5b2fe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css-loader/cjs.js: e.charCodeAt is not a function
1 participant