Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for token and tokenPayload are incorrect #134

Open
Tracked by #135
nightpool opened this issue Dec 9, 2021 · 0 comments
Open
Tracked by #135

Docs for token and tokenPayload are incorrect #134

nightpool opened this issue Dec 9, 2021 · 0 comments
Milestone

Comments

@nightpool
Copy link

The docs for token and tokenPayload say

If the user is loggedIn(), the token will be returned immediate, else it will open a popup and wait until the user is loggedIn() (i.e. a new token has been added)."

However, this is incorrect. token() and tokenPayload() do not open a popup on their own, they have to be used in combination .

IMO, this is pretty inconvenient for an implementor. It would be better if token() and tokenPayload() matched the documented behavior, and just "did the right thing" automatically depending on whether the user was logged in or not.

@ricokahler ricokahler mentioned this issue Dec 9, 2021
4 tasks
@ricokahler ricokahler added this to the v2.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants