Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--favorites only pulling the first page #281

Closed
edgar1016 opened this issue Apr 8, 2023 · 0 comments · Fixed by #282
Closed

--favorites only pulling the first page #281

edgar1016 opened this issue Apr 8, 2023 · 0 comments · Fixed by #282

Comments

@edgar1016
Copy link
Contributor

nhentai/nhentai/cmdline.py

Line 80 in 57673da

parser.add_option('--page', '--page-range', type='string', dest='page', action='store', default='1',

cmdline.py was changed in aa77cb1 to where --page default is now default='1' causing --favorite to only look through the first page. Changing it back to default='' fixes the issue.

Not sure which way is best to handle it changing the default or allowing for a --page-all with --favorites since it currently doesn't work with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

--page-all works with favorites edgar1016/nhentai
1 participant
@edgar1016