Enable the rubocop-rake and rubocop-rspec gems
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project dependencies now allow rack 3 to be installed. This backwards incompatible version extracted handlers in a new `rackup` gem. While we could indicate we prefer to use rack 2 which is still receiving update, it is more future-proof to update our code to be compatible with the latest version of the dependency. This is a development dependency only so will not affect users of the project.
Under normal operation, we have a single instance of the `Riemann::Tools::HttpCheck` class for the lifetime of the monitoring process. But when testing, we create a new instance for each test, each with its resolvers and worker thread pools. The test process will have more and more threads, until it eventually hit the OS limit of the maximum number of threads for a process and cause an exception: > ThreadError: can't create Thread: Resource temporarily unavailable Make sure that the threads are terminated at the end of each test to avoid running out of resources if they are limited.
The `rubocop-rake` and `rubocop-rspec` are listed as dependencies, but they where not enabled in rubocop configuration. Enable them, and disable a bunch of cops that are not relevant at this point.
These are generaly smells, but here it makes our life simple, so just ignore these cops in this situation.
RSpec/EmptyLineAfterExampleGroup: Add an empty line after context. RSpec/EmptyLineAfterSubject: Add an empty line after subject. RSpec/EmptyLineAfterFinalLet: Add an empty line after the last let.
New cops are not enabled by default by rubocop because they can be disruptive. They are however relevant regarding the code quality, and because the activity on the project is rather low, enable them.
…e it is implied by default.
…arying precedence with parentheses to avoid ambiguity
smortex
commented
Jan 21, 2024
| { state: 'warning' } | ||
| {} |
There was a problem hiding this comment.
I guess this is a bug? In this case we should extract it to another PR with a bug label so that it appears clearly in the changelog. Or maybe I miss something?
smortex
commented
Jan 21, 2024
Comment on lines
+10
to
+11
| Gemspec/RequireMFA: | ||
| Enabled: false |
There was a problem hiding this comment.
I would prefer to require the usage of MFA, but according to rubygems.org "(some) owners are not using multi-factor authentication (MFA)."
There was a problem hiding this comment.
It's @aphyr - when you get a chance, could you enable MFA on RubyGems if that works? Thanks!
There was a problem hiding this comment.
Awesome! I opened #286 to address this.
jamtur01
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop is not configured to detect and help fixing all issues it can spot. Enable this code to improve further the code of the gem.
Also include:
Riemann::Tools::HttpCheckthreads between tests #284