Terminate Riemann::Tools::HttpCheck threads between tests
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project dependencies now allow rack 3 to be installed. This backwards incompatible version extracted handlers in a new `rackup` gem. While we could indicate we prefer to use rack 2 which is still receiving update, it is more future-proof to update our code to be compatible with the latest version of the dependency. This is a development dependency only so will not affect users of the project.
Under normal operation, we have a single instance of the `Riemann::Tools::HttpCheck` class for the lifetime of the monitoring process. But when testing, we create a new instance for each test, each with its resolvers and worker thread pools. The test process will have more and more threads, until it eventually hit the OS limit of the maximum number of threads for a process and cause an exception: > ThreadError: can't create Thread: Resource temporarily unavailable Make sure that the threads are terminated at the end of each test to avoid running out of resources if they are limited.
smortex
force-pushed
the
terminate-threads-in-tests
branch
from
6df45cf
to
c4f0df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under normal operation, we have a single instance of the
Riemann::Tools::HttpCheckclass for the lifetime of the monitoring process.But when testing, we create a new instance for each test, each with its resolvers and worker thread pools. The test process will have more and more threads, until it eventually hit the OS limit of the maximum number of threads for a process and cause an exception:
Make sure that the threads are terminated at the end of each test to avoid running out of resources if they are limited.
Also include: