Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in CurrentUrlPath of BrowserWrapper #17

Open
tomasherceg opened this issue Jul 12, 2024 · 2 comments · May be fixed by #19
Open

Bug in CurrentUrlPath of BrowserWrapper #17

tomasherceg opened this issue Jul 12, 2024 · 2 comments · May be fixed by #19

Comments

@tomasherceg
Copy link
Member

If I understand correctly, the browser.CurrentUrlPath should return the path component of the URL.
However, the following line returns the entire URL.

public string CurrentUrlPath => new Uri(CurrentUrl).GetLeftPart(UriPartial.Path);

I guess it can be changed to AbsolutePath to fix the behavior.

Can you please confirm that I understand correctly what the property shall do so that I can create a PR?

@quigamdev
Copy link
Contributor

Yes, only the path of the URL should be returned (without host).

@quigamdev
Copy link
Contributor

I have opened PR for this issue. Please review it and feel free to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants