Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaNs should be transparent independent of threshold #7

Closed
chrisgorgo opened this issue Dec 26, 2013 · 3 comments
Closed

NaNs should be transparent independent of threshold #7

chrisgorgo opened this issue Dec 26, 2013 · 3 comments

Comments

@chrisgorgo
Copy link
Contributor

See http://neurovault.org/images/76/
and
http://neurovault.org/media/r3D-2D_comp1_005_108.nii.gz

@rii-mango
Copy link
Owner

I think you are right about this. I'll get it fixed...

@chrisgorgo
Copy link
Contributor Author

Thanks! I guess it's a question of adding isnan somewhere, but I could not figure out where the actual thresholding is done.

@rii-mango
Copy link
Owner

You can change this line in classes/viewer/screenslice.js (around line 94):

if ((!this.screenVolumes[ctr].negative && (value <= this.screenVolumes[ctr].screenMin))
    || (this.screenVolumes[ctr].negative && (value >= this.screenVolumes[ctr].screenMin)) 
    || isNaN(value)) {  // add this part

rii-mango added a commit that referenced this issue Jan 2, 2014
NaN should be transparent. Fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants