Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsnr is not used, what is the use of this variable? #55

Closed
l2009312042 opened this issue Jan 20, 2022 · 4 comments
Closed

lsnr is not used, what is the use of this variable? #55

l2009312042 opened this issue Jan 20, 2022 · 4 comments

Comments

@l2009312042
Copy link

lsnr = self.lsnr_fc(emb) * self.lsnr_scale + self.lsnr_offset

i found in the code, this variable is calculated, but not used for loss and other place ,so what is the use of this target?

@Rikorose
Copy link
Owner

This is a frame-level SNR prediction. This can be used for a voice detection or to turn of the decoder/dfnet for parts where we only have noise (e.g. here)

@l2009312042
Copy link
Author

l2009312042 commented Jan 20, 2022

thanks , this make sense .
but i have another question, in your above answer ,when lsnr < -15,the df is on.
but in the paper ,the df is not good for noise part ,those two are contradictory, how to explain this?
image

@Rikorose
Copy link
Owner

Oh yea. It should be off, i.e. the other way round. The PR that I linked is not merged and could have some bugs.

But what the paper states is enforced via alpha.
I.e. here

df_coefs, df_alpha = self.df_dec(emb, c0)

and here
class DfAlphaLoss(nn.Module):

@l2009312042
Copy link
Author

l2009312042 commented Jan 20, 2022

thx,i got it
the follow is my understanding of the alpha loss

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants