Allow to control click and context propagation #141
Conversation
jkanban.js
Outdated
| @@ -54,8 +54,8 @@ var dragula = require('dragula'); | |||
| dragBoard: function (el, source) {}, | |||
| dragendBoard: function (el) {}, | |||
| dropBoard: function (el, target, source, sibling) {}, | |||
| click: function (el) {}, | |||
| context: function (el, e) {}, | |||
| click: null, | |||
There was a problem hiding this comment.
I would not recommend that. I guess it would be nice to have a kind of property or even a callback function to get if user wants to have native click or context.
jkanban.js
Outdated
| @@ -508,6 +508,9 @@ var dragula = require('dragula'); | |||
| } | |||
|
|
|||
| function __onclickHandler (nodeItem, clickfn) { | |||
| if (typeof self.options.click !== 'function') { | |||
There was a problem hiding this comment.
See that browser event is cancelled by preventDefault method. So if we have a property to control if jKanban has to propagate click or context this if will be simpler like ´if (!self.ownedHandlers.includes('click')) { return }`
jkanban.js
Outdated
| @@ -516,6 +519,9 @@ var dragula = require('dragula'); | |||
| } | |||
|
|
|||
| function __onContextHandler(nodeItem, contextfn) { | |||
| if (typeof self.options.context !== 'function') { | |||
There was a problem hiding this comment.
And then here we can check ownedHandlers as well like ´if (!self.ownedHandlers.includes('context')) { return }`
jkanban.js
Outdated
| click: function (el) {}, | ||
| context: function (el, e) {}, | ||
| click: null, | ||
| context: null, |
There was a problem hiding this comment.
Thinking about that, I could suggest you to create a property called ownedHandlers or so, in order to control what event jKanban will handle ('click', 'context').
ngmy
changed the title
|
@marcosrocha85 |
|
Merged, thanks @ngmy |
I think it's more convenient to enable browser click and right-click by default.
For example, click to open URL in an item, or right-click to use the browser developer tool.