Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehole import persists even after calling "Remove all typeholes from all files" #9

Open
sevenfields-matt opened this issue May 17, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@sevenfields-matt
Copy link

I think the import for typehole should also be removed if you call remove all typeholes from all files.

Repro:

  1. Run command "Remove all typeholes from all files"
  2. Notice import still exists.
@rikukissa
Copy link
Owner

Quick question about this: did you have typeholes still in the file with the import when you ran the command?

The logic for removing the imports is there, but I think it only applies to files that still have typeholes

@rikukissa rikukissa added the bug Something isn't working label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants