Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Additional MFi inputs #33

Closed
wants to merge 3 commits into from
Closed

Feature: Additional MFi inputs #33

wants to merge 3 commits into from

Conversation

ianclawson
Copy link

@ianclawson ianclawson commented Jul 3, 2021 •
edited
Loading

This PR adds change handlers that listen to new MFi inputs added since iOS 12, which are:

  • leftThumbstickButton
  • rightThumbstickButton
  • buttonOptions
  • buttonHome

// specific to GCDualShockGamepad/GCDualSenseGamepad

  • touchpadButton

// specific to GCXboxGamepad

  • paddleButton1
  • paddleButton2
  • paddleButton3
  • paddleButton4

Corresponding Delta PR: rileytestut/Delta#135

Notes:

  • while this PR adds some handling for PS/Xbox controller-specific buttons, it does not add all PS/Xbox controller-specific features (such as the TouchPad and the LightBar). I have tested with both an MFi controller as well as the PS5's DualSense and found both to be working as expected.
  • now that Controller.gamepad is deprecated, I've moved the input handling for the existing inputs over to Controller.extendedGamepad

Semi-related Trello card (because the full card is not yet implemented): https://trello.com/c/0DQQD9Zg

@ianclawson ianclawson mentioned this pull request Jul 3, 2021
Closed
@ianclawson ianclawson changed the title Feature: Additional (agnostic MFi) inputs Feature: Additional MFi inputs Jul 5, 2021
This was referenced Oct 24, 2021
Open
Open
@ianclawson
Copy link
Author

Closing this to clean up my work list of Open PRs

@ianclawson ianclawson closed this Aug 6, 2022
@CooperCorona CooperCorona mentioned this pull request Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ianclawson