Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dockerfile] -d while Installing npm dependencies. #562

Closed
AshishKapoor opened this issue Jul 15, 2022 · 0 comments
Closed

[Dockerfile] -d while Installing npm dependencies. #562

AshishKapoor opened this issue Jul 15, 2022 · 0 comments
Labels
nit Nit Issue Type

Comments

@AshishKapoor
Copy link

Describe the bug
Curious, why there's a -d flag and not simply npm i or npm ci in the Dockerfile?

RUN echo "Installing npm dependencies..." && \
    npm install -d

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/rilldata/rill-developer/blob/4db2c267f64e80817c627704c854fe359003dc6e/Dockerfile#L14

Expected behavior
Can we use npm i or npm ci?

Screenshots
If applicable, add screenshots to help explain your problem.
NA

Desktop (please complete the following information):

  • OS: ubuntu server 20.04
  • Browser chrome
  • Version 103.0.5060.114 (Official Build) (arm64)
@AshishKapoor AshishKapoor added the nit Nit Issue Type label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nit Nit Issue Type
Projects
None yet
Development

No branches or pull requests

1 participant