Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master branch broken and no tagged release versions #3

Closed
KantarBruceAdams opened this issue Jul 18, 2019 · 2 comments
Closed

master branch broken and no tagged release versions #3

KantarBruceAdams opened this issue Jul 18, 2019 · 2 comments

Comments

@KantarBruceAdams
Copy link

Hi,
The current head commit doesn't work (for me anyway) as follows:


go get github.com/rillig/gobco
go: downloading github.com/rillig/gobco v0.0.0-20190712181434-65bb23983152
go: downloading github.com/google/uuid v1.1.1
# github.com/rillig/gobco
/main.go:82:16: undefined: os.UserHomeDir
../../../go/pkg/mod/github.com/rillig/gobco@v0.0.0-20190712181434-65bb23983152/main.go:204:24: exitErr.ExitCode undefined (type *exec.ExitError has no field or method ExitCode)

Apologies if this is teaching your grandmother to suck eggs but I would recommend having separate feature branches for experimental changes and keeping only tagged release versions on the master branch. See for example, https://datasift.github.io/gitflow/IntroducingGitFlow.html

Regards,

Bruce.

@KantarBruceAdams
Copy link
Author

I would suggest tagging commit ff234e5 as 1.0.0 (or maybe 0.1.0) as it predates the latest tinkering.

@rillig
Copy link
Owner

rillig commented Jul 18, 2019

Regarding your suggestion of adding feature branches: I won't do this right now because I always think of the master branch as being as stable and useful as possible. Granted, before copying everything to a temporary directory, gobco wasn't even ready to be used reliably, but feature branches wouldn't have changed this.

Feature branches also wouldn't have caught this use of new API. Therefore the argument of adding feature branches is moot in this particular case. It worked properly for me, I had tested it, therefore I considered it stable enough to be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants