fix(config/plugins.h): memory leak caused by non-virtual destructor

Closes #259
rime · Mar 5, 2019 · 316a659 · 316a659
1 parent 7076d9e
commit 316a659
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/rime/config/plugins.h b/src/rime/config/plugins.h
@@ -17,6 +17,8 @@ class ConfigCompilerPlugin {
   typedef bool Review(ConfigCompiler* compiler,
                       an<ConfigResource> resource);
 
+  virtual ~ConfigCompilerPlugin() = default;
+
   virtual Review ReviewCompileOutput = 0;
   virtual Review ReviewLinkOutput = 0;
 };
@@ -57,7 +59,7 @@ struct ResourceType;
 class SaveOutputPlugin : public ConfigCompilerPlugin {
  public:
   SaveOutputPlugin(const ResourceType& output_resource);
-  ~SaveOutputPlugin();
+  virtual ~SaveOutputPlugin();
 
   Review ReviewCompileOutput;
   Review ReviewLinkOutput;