Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a distinction between swipe and tap #32

Closed
otsaloma opened this issue Feb 24, 2018 · 3 comments
Closed

Make a distinction between swipe and tap #32

otsaloma opened this issue Feb 24, 2018 · 3 comments

Comments

@otsaloma
Copy link
Contributor

Currently when I tap, e.g. a POI icon on the map, the map usually moves a little bit, which I assume means that the tap is detected as both a swipe (pan) and a tap. It looks quite distracting. Can you make a distinction between these – some kind tolerance that a swipe has to cross? For comparison, QtLocation gets this right.

@rinigus
Copy link
Owner

rinigus commented Feb 24, 2018

Unless I figure out how to get map guesture area from QtLocation ported to this plugin (#24), interaction is guided by https://github.com/rinigus/mapbox-gl-qml/blob/master/src/plugin/MapboxMapGestureArea.qml .

Porting QtLocation map interaction was rather non-trivial. There is a lot of interaction between different components that are absent or replaced in this plugin. In particular, since this plugin is Mapbox GL centered, lots of abstractions were not needed. However, I would expect that lots of work has been done on Qt side to make it feel just right. So, I may try to look into it again and see if I can carry it over in some form. But it may take some time before I can look into it and I am not 100% sure I can do it in reasonable amount of time.

Currently, probably the best would be to change MapboxMapGestureArea.qml in a way that such mixing would not occur. Should be possible, just would have to figure out how and what would be tolerances. Do you want to look into it?

@otsaloma
Copy link
Contributor Author

I could take a look at MapboxMapGestureArea.qml, but I'll first do the remaining stuff on the WhoGo Maps side, so it could be a while.

@rinigus
Copy link
Owner

rinigus commented Feb 25, 2018

Good. Let's see who gets there first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants