Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for protein/ligand RE-EDS + plot/bug fixes #65

Merged
merged 49 commits into from
May 20, 2022
Merged

Updates for protein/ligand RE-EDS + plot/bug fixes #65

merged 49 commits into from
May 20, 2022

Conversation

candidechamp
Copy link
Collaborator

@candidechamp candidechamp commented May 6, 2022

Description

This branch contains a few tweaks and additions to the code which should work for everyone using RE-EDS and pygromos v1.
(code should be used with the PygromosTools_V1.2 branch)

Notable things which changed in this branch:

  • Input preparation between steps b (lower bound search) and c (energy offset estimation) now places automatically s-values in the gap region such that a total of 32 s-values make up the initial distribution (this may then be optimized using GRTO).

-Input preparation of ssm configurations now uses the lowest energy conformer of the second half of the 1ns simulation in the optimized state (step a). This is the step which requires the updated pygromos code.

-Modified the plot summarizing the (s)-optimization and energy offset rebalancing steps (added error bars, and changed the s-distribution plot).

-Modified the plots found in analysis/state_sampling folders such that the correct data is shown for the occurrence state sampling, and to make plots slightly clearer.
(an option is now available to display/hide the raw data which was previously always written on the plot).

-Various print statements have been removed as well as a duplicate function.

Todos

Notable points that this PR has either accomplished or will accomplish.

Questions

  • Question1

Status

  • Ready to go

Do not merge before we agree that all the code works for everyone.

Candide Champion added 30 commits February 9, 2022 11:56
@lgtm-com
Copy link

lgtm-com bot commented May 11, 2022

This pull request introduces 3 alerts and fixes 3 when merging 8a60649 into 64f4a4a - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Unused import
  • 1 for Unreachable code

fixed alerts:

  • 2 for Variable defined multiple times
  • 1 for Unused import

…n + make sure optimized state directory is passed properly to job_analysis.py
@lgtm-com
Copy link

lgtm-com bot commented May 13, 2022

This pull request introduces 3 alerts and fixes 3 when merging b52e69f into 64f4a4a - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Unused import
  • 1 for Unreachable code

fixed alerts:

  • 2 for Variable defined multiple times
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 16, 2022

This pull request introduces 3 alerts and fixes 3 when merging f68df71 into 64f4a4a - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Unused import
  • 1 for Unreachable code

fixed alerts:

  • 2 for Variable defined multiple times
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request introduces 3 alerts and fixes 3 when merging a82f320 into 64f4a4a - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Unused import
  • 1 for Unreachable code

fixed alerts:

  • 2 for Variable defined multiple times
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request introduces 2 alerts and fixes 3 when merging 3446609 into 64f4a4a - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Unused import

fixed alerts:

  • 2 for Variable defined multiple times
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request fixes 3 alerts when merging 7e9f3b8 into 64f4a4a - view on LGTM.com

fixed alerts:

  • 2 for Variable defined multiple times
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2022

This pull request fixes 3 alerts when merging 3fc2ebf into 64f4a4a - view on LGTM.com

fixed alerts:

  • 2 for Variable defined multiple times
  • 1 for Unused import

@candidechamp candidechamp merged commit 84ac08d into rinikerlab:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants