Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EphemKernel useability #26

Open
1 of 4 tasks
altairgomes opened this issue Jun 3, 2020 · 3 comments
Open
1 of 4 tasks

Improve EphemKernel useability #26

altairgomes opened this issue Jun 3, 2020 · 3 comments
Labels
effort_medium It may take some time to solve enhancement New feature or request ephem

Comments

@altairgomes
Copy link
Collaborator

altairgomes commented Jun 3, 2020

Some tests should be made to ensure the readability and useability of the EphemKernel Class. These tests should include:

  • Test if the kernel is available, is an allowed kernel and can determine the path from geocenter to the object.
  • Determine and show to the user the limit of time the ephemeris can be calculated.
  • Be able to define and save a default path where the kernels are stored.
  • change code to spkid
@altairgomes altairgomes added enhancement New feature or request effort_medium It may take some time to solve ephem labels Jun 3, 2020
@Bmorgado19
Copy link
Collaborator

Maybe it would be interesting to change the parameter code within the EphemKernel to spkid. This would avoid misconceptions about the word code.

@altairgomes
Copy link
Collaborator Author

We can also add a query to the SBDB to get the spkid automatically. This can be based on the following codelines suggested by @martinBanda .

from astroquery.jplsbdb import SBDB
sbdb = SBDB.query('1999 RC216')
obj = sbdb['object']
spkid = obj['spkid']
print(spkid)

@martinBanda
Copy link
Collaborator

martinBanda commented Jun 5, 2020

Follows three ways to get the spk id:

  1. Searching in the header of the bsp file.
  2. Using the SBDB function from jplsbdb module (comment above by @altairgomes )
  3. Using a API (process similar to item 2)

Being the item (1) the most efficient way (according to me), because it only depends on the existence of the bsp file avoiding query time.

I have developed the codes to get spk id using any of the three methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort_medium It may take some time to solve enhancement New feature or request ephem
Projects
None yet
Development

No branches or pull requests

3 participants