Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use instance constructors to create new object instances #458

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: only use instance constructors to create new object instances #458

merged 1 commit into from
May 23, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented May 23, 2023

Exclude static constructors and only consider instance constructors to create new objects.

@latonz latonz self-assigned this May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #458 (c191d9f) into main (b17f666) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   92.08%   92.22%   +0.14%     
==========================================
  Files         135      135              
  Lines        4282     4295      +13     
  Branches      591      590       -1     
==========================================
+ Hits         3943     3961      +18     
+ Misses        225      223       -2     
+ Partials      114      111       -3     
Impacted Files Coverage Δ
...lders/NewInstanceObjectMemberMappingBodyBuilder.cs 78.78% <100.00%> (ø)
.../Descriptors/MappingBuilders/CtorMappingBuilder.cs 73.33% <100.00%> (+4.10%) ⬆️
...iptors/MappingBuilders/EnumerableMappingBuilder.cs 97.57% <100.00%> (+3.06%) ⬆️
...Mapperly/Descriptors/UserMethodMappingExtractor.cs 92.98% <100.00%> (+0.04%) ⬆️
src/Riok.Mapperly/Helpers/SymbolExtensions.cs 89.47% <100.00%> (+0.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz enabled auto-merge (squash) May 23, 2023 06:38
@latonz latonz requested a review from ni507 May 23, 2023 06:38
@latonz latonz merged commit 848fb45 into riok:main May 23, 2023
@latonz latonz deleted the fix/use-instance-constructors branch May 23, 2023 06:56
@github-actions
Copy link

🎉 This PR is included in version 2.9.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@latonz latonz added this to the v2.9.0 milestone Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants