Tag based router #80

Merged
merged 8 commits into from Jan 29, 2017

Conversation

Projects
None yet
2 participants
@cognitom
Member

cognitom commented Dec 24, 2016

See #79

@GianlucaGuarini GianlucaGuarini referenced this pull request in riot/riot Jan 21, 2017

Closed

Riot doesn't have a way of mounting tags received from xhr request #2231

3 of 6 tasks complete
@cognitom

This comment has been minimized.

Show comment
Hide comment
@cognitom

cognitom Jan 29, 2017

Member

I was waiting that rollup-plugin-node-resolve supports modules.root... but unfortunately there was no activity on it this month. I'm merging this and will think about it later again.
Let's go!

Member

cognitom commented Jan 29, 2017

I was waiting that rollup-plugin-node-resolve supports modules.root... but unfortunately there was no activity on it this month. I'm merging this and will think about it later again.
Let's go!

@cognitom cognitom changed the base branch from master to dev Jan 29, 2017

@cognitom cognitom merged commit 4ebf644 into dev Jan 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cognitom cognitom deleted the feature/route-tag branch Jan 29, 2017

@cognitom

This comment has been minimized.

Show comment
Hide comment
@cognitom

cognitom Jan 29, 2017

Member

Hi @GianlucaGuarini, can I release riot-route@3.1.0?
This is a new feature, so basically we should npm version minor. Or should we stick to 3.0.x with Riot's version number?

Member

cognitom commented Jan 29, 2017

Hi @GianlucaGuarini, can I release riot-route@3.1.0?
This is a new feature, so basically we should npm version minor. Or should we stick to 3.0.x with Riot's version number?

@GianlucaGuarini

This comment has been minimized.

Show comment
Hide comment
@GianlucaGuarini

GianlucaGuarini Jan 29, 2017

Member

riot-route3.1.0 is fine to me, I probably will release riot@3.1.0 today as well. Remember to update the doc that I will automatically import on our site

Member

GianlucaGuarini commented Jan 29, 2017

riot-route3.1.0 is fine to me, I probably will release riot@3.1.0 today as well. Remember to update the doc that I will automatically import on our site

@cognitom

This comment has been minimized.

Show comment
Hide comment
@cognitom

cognitom Jan 29, 2017

Member

@GianlucaGuarini ok, thanks! Will do.

I probably will release riot@3.1.0 today as well.

Great!

Member

cognitom commented Jan 29, 2017

@GianlucaGuarini ok, thanks! Will do.

I probably will release riot@3.1.0 today as well.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment