Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag based router #80

Merged
merged 8 commits into from
Jan 29, 2017
Merged

Tag based router #80

merged 8 commits into from
Jan 29, 2017

Conversation

cognitom
Copy link
Member

See #79

@GianlucaGuarini GianlucaGuarini mentioned this pull request Jan 21, 2017
Closed
6 tasks
@cognitom
Copy link
Member Author

cognitom commented Jan 29, 2017 •
edited
Loading

I was waiting that rollup-plugin-node-resolve supports modules.root... but unfortunately there was no activity on it this month. I'm merging this and will think about it later again.
Let's go!

@cognitom cognitom changed the base branch from master to dev January 29, 2017 08:46
@cognitom cognitom merged commit 4ebf644 into dev Jan 29, 2017
@cognitom cognitom deleted the feature/route-tag branch January 29, 2017 08:49
@cognitom
Copy link
Member Author

Hi @GianlucaGuarini, can I release riot-route@3.1.0?
This is a new feature, so basically we should npm version minor. Or should we stick to 3.0.x with Riot's version number?

@GianlucaGuarini
Copy link
Member

riot-route3.1.0 is fine to me, I probably will release riot@3.1.0 today as well. Remember to update the doc that I will automatically import on our site

@cognitom
Copy link
Member Author

@GianlucaGuarini ok, thanks! Will do.

I probably will release riot@3.1.0 today as well.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cognitom @GianlucaGuarini