Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yo can use brackets <% %> anymore #3

Closed
aMarCruz opened this issue Oct 3, 2015 · 1 comment
Closed

Yo can use brackets <% %> anymore #3

aMarCruz opened this issue Oct 3, 2015 · 1 comment

Comments

@aMarCruz
Copy link
Contributor

aMarCruz commented Oct 3, 2015

This popular brackets from ASP looks great, but is causing many issues in riot.

ASP parses their files and then send the result to the html parser.
riot, by contrast, receives the tags from the html parser, probably altered. This is causing confusion to users that believe riot is a sort of ASP.

Also, the character > complicates the detection of tag elements, especially attributes. The compiler and tmpl are using the same function to separate expressions from markup: the new brackets.split function. brackets.split needs to be light because it must be included in riot, even without the compiler.

This new brackets function is the bridge between custom brackets, tmpl and the compiler, 'cause tmpl can receive the full body of a tag element and, practically, compile it from scratch (think about <yield> as example).

@tipiirai
Copy link

tipiirai commented Oct 5, 2015

I think we can drop the support for < > characters on custom brackets. I can see the challenges it causes. Just needs to be documented, that's all.

@aMarCruz aMarCruz closed this as completed Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants