Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localised decimal separator #112

Open
rcasula opened this issue Aug 2, 2023 · 6 comments
Open

Localised decimal separator #112

rcasula opened this issue Aug 2, 2023 · 6 comments
Assignees
Labels
backend This is backend related

Comments

@rcasula
Copy link
Contributor

rcasula commented Aug 2, 2023

Use the system default decimal separator instead of the hardcoded ..

@theperu theperu added the backend This is backend related label Aug 9, 2023
@GBergatto
Copy link
Contributor

Currently, we are using commas and periods inconsistently across the app. The best way to solve this is, as suggested by @rcasula, to read the local of the user. However, in this early stage we could start with the English locale as default, using dot as decimal separator and comma as thousands separator.

@theperu
Copy link
Collaborator

theperu commented Aug 10, 2023

I agree with @GBergatto since the app is in English I think we should stick with . for the decimals and , for the thousands

@Votyer
Copy link

Votyer commented Dec 1, 2023

I'll take care of it

@Votyer
Copy link

Votyer commented Dec 2, 2023

Hello everyone, short update from my task.
I changed the method "numToCurrency" in functions class so now it accept the locale as parameter.
Addictionally I added the flutter lib for string internationalizing(link below) to support different languages.

I hope to close this task before the end next week

Internationalizing Flutter apps
https://docs.flutter.dev/ui/accessibility-and-internationalization/internationalization

@theperu
Copy link
Collaborator

theperu commented Dec 3, 2023

Great! We'll wait for the PR then!

@Votyer
Copy link

Votyer commented Dec 19, 2023

PR Opened sorry for delay!
#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This is backend related
Projects
None yet
Development

No branches or pull requests

4 participants