Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks for Pull Requests #139

Closed
theperu opened this issue Jan 23, 2024 · 4 comments
Closed

Fix checks for Pull Requests #139

theperu opened this issue Jan 23, 2024 · 4 comments
Assignees
Labels
GitHub This is related to how we are using GitHub

Comments

@theperu
Copy link
Collaborator

theperu commented Jan 23, 2024

For a while we had this issue that the checks fail for every new PR. From my understanding we are using the wrong Dart SDK version (3.1.0) while it should be >=3.1.5 and <4.0.0

@theperu theperu added the GitHub This is related to how we are using GitHub label Jan 23, 2024
@mikev-cw
Copy link
Collaborator

Yeah, problem is surely this. Workflow configuration file, however, is correctly running on SDK version 3.16.0 as you can see here:

flutter-version: '3.16.5'

So it's not clear to me where the problem is.. i will try to investigate further

@theperu
Copy link
Collaborator Author

theperu commented Jan 25, 2024

Maybe we could try running flutter upgrade --dart just to make sure that we have the latest compatible version of Dart?

@mikev-cw
Copy link
Collaborator

I don't think this is related to our local environments. Now seems that clearing GH Actions cache (again) does the job... let me check again on that on next days.

...but now there are a couple of problems on tests, which were hidden 'till now by this issue! 🤣

@theperu
Copy link
Collaborator Author

theperu commented Jan 25, 2024

Understood 👍🏻😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub This is related to how we are using GitHub
Projects
None yet
Development

No branches or pull requests

2 participants