Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C when the subtitle list is not open quits Memento #67

Closed
Calvin-Xu opened this issue Jan 15, 2022 · 4 comments
Closed

Ctrl-C when the subtitle list is not open quits Memento #67

Calvin-Xu opened this issue Jan 15, 2022 · 4 comments
Labels
question Further information is requested wontfix This will not be worked on

Comments

@Calvin-Xu
Copy link
Contributor

Ctrl-C is implemented as a shortcut in SubtitleListWidget that copies the current context to clipboard. When the subtitle list is not currently open, the shortcut quits Memento. I guess the implementation implies this, but it is not very intuitive. I suppose the expected behavior is that the current line will be copied, like how context behaves when adding to Anki even when the subtitle list is not visible. On the other hand, Shift-Ctrl-C does not do anything when the subtitle list is not open and does not quit Memento.

@ripose-jp ripose-jp added question Further information is requested wontfix This will not be worked on labels Jan 15, 2022
@ripose-jp
Copy link
Owner

Not changing default mpv binds is one of the design philosophies of Memento.

Add Ctrl+c ignore to your input.conf to change the behavior.

@Calvin-Xu
Copy link
Contributor Author

I see. I always thought q is the keybind to quit. Qt remaps Command to Ctrl on Mac and passes to mpv so it was confusing.

@ripose-jp
Copy link
Owner

The whole quitting with ctrl+c thing is probably a homage to killing things with ctrl+c on Unix. The only difference between it an q is that ctrl+c quits mpv with an exit code of 4, though Memento will still quit with 0.

@Calvin-Xu
Copy link
Contributor Author

Calvin-Xu commented Jan 16, 2022

Yeah. It's just that on Mac, Ctrl-C in Memento does not quit because I think Ctrl gets mapped to Meta by Qt, but Cmd-C does. In (standalone) mpv the opposite is true (Ctrl is Ctrl, Cmd is Meta). I think this applies to everything else. Not sure if you'd consider this changing default mpv keybindings; it's pretty consistent so I don't feel it's a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants