Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ledger parameters in tx command and deprecate/remove transaction_entry #2598

Open
mDuo13 opened this issue Jun 22, 2018 · 2 comments
Labels
Milestone

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Jun 22, 2018

Aside from #2597, the only advantage the transaction_entry command has over the tx command is that you can use it to query for a particular transaction in a single ledger version. Adding the standard ledger-lookup options (ledger_index & ledger_hash) to the tx method would make tx's proper functionality a strict superset of transaction_entry. After doing so, we could simplify the API by removing the transaction_entry method.

If the request specifies a ledger with ledger_index / ledger_hash (or maybe even the deprecated ledger field), the tx command should query only the specified ledger. If the requested transaction hash is not included in the specified ledger, the method should return a txnNotFound error.

@carlhua
Copy link
Contributor

carlhua commented Sep 16, 2020

Consider this for API v2

@intelliot intelliot added the Good First Issue Great issue for a new contributor label Sep 8, 2023
@intelliot intelliot added this to the api_version 3 milestone Sep 21, 2023
@intelliot
Copy link
Collaborator

Low priority - postponing to api_version 3 (2024)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants