rv32im circuit updates #1690
Merged
rv32im circuit updates #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
flaub
force-pushed
the
flaub/rv32im-update
branch
from
40a7968
to
84d916a
Compare
flaub
commented
Apr 23, 2024
| @@ -136,8 +136,7 @@ impl KernelBuild { | |||
|
|
|||
| fn compile_cuda(&mut self, output: &str) { | |||
| println!("cargo:rerun-if-env-changed=RISC0_CUDA_OPT"); | |||
| println!("cargo:rerun-if-env-changed=NVCC_PREPEND_FLAGS"); | |||
| println!("cargo:rerun-if-env-changed=NVCC_APPEND_FLAGS"); | |||
| println!("cargo:rerun-if-env-changed=RISC0_NVCC_FLAGS"); | |||
jbruestle
approved these changes
Apr 23, 2024
tzerrell
approved these changes
Apr 23, 2024
nategraf
approved these changes
Apr 23, 2024
| #[cfg_attr(feature = "export-syscalls", no_mangle)] | ||
| pub extern "C" fn sys_input(index: u32) -> u32 { | ||
| let t0 = ecall::INPUT; | ||
| let index = index & 0x07; |
There was a problem hiding this comment.
Why is it important that this does not panic? My default here would have been to panic is out of range.
There was a problem hiding this comment.
Panic in this codepath would cause a lot of bloat. Ideally this function could be inlined. Generally I don't like the idea of the low-level sys- functions doing a panic. We should maybe have them return error codes (I'd say Result but it'd be nice for these functions to be callable from C). I also don't know how C will handle panics, so another reason to avoid panic from these functions.
There was a problem hiding this comment.
Ok, that's helpful context
Comment on lines
-476
to
-482
| .clone(); | ||
| post.pc = post | ||
| .pc | ||
| .checked_sub(WORD_SIZE as u32) | ||
| .ok_or(VerificationError::ReceiptFormatError)?; | ||
| post.digest() | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVCC_PREPEND_FLAGSandNVCC_APPEND_FLAGSwithRISC0_NVCC_FLAGS. IfRISC0_NVCC_FLAGSis not set, then-arch=nativeis used as a default.sys_inputwhich is a syscall that guests can use to access the input digest that is optionally specified for each proof request.Digest::ZEROwhen the exit code isHalted.