Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building and running without Metal on MacOS #323

Closed
wants to merge 1 commit into from

Conversation

nategraf
Copy link
Contributor

@nategraf nategraf commented Jan 6, 2023

Metal is currently required as a build dependency on MacOS even if it will not be used. As a result,
the codebase cannot be built without it.

This PR refactors the use of Metal to gate building dependant code behind the "metal" feature flag.
As an alternative to the current method, this means users may have to explicitly enable "metal" as a
feature at build-time (if the turn off defeault features).

@flaub
Copy link
Member

flaub commented Jan 6, 2023

I think the challenge here is how to convince cargo to build on non-macos platforms in such a way that doesn't include the metal crate. The previous attempt was using the target.'cfg(target_os = "macos")'.dependencies] approach because of this problem. It'd be interesting to see if we can feature flag this dependency.

@nategraf
Copy link
Contributor Author

Superseded by #348

@nategraf nategraf closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants