risc0-sys crate / HAL refactor #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes additional dependency links with the circuit crate, should help with rebuild times in certain edit patterns of the src tree.
Building but does not pass receipt verification tests
This allows the code and build system to be leaf node in the dependency graph and should prevent regular rebuilds of the native code.
Fully moved all major components into the new risc0-sys crate, wired together the required env var propogation between the different crates that depend on the HAL components. CPU is working, cuda is failing tests, metal is un-tested. I also added a manual cache system to provide a developer a fast-pass way to bypass rebuild if needed (useful for CUDA builds mostly)
flaub
reviewed
Jan 25, 2023
Fixes risc0-build depending on the 'prove' feature for zkvm, causing duplicate builds of libcircuit.a
|
Moving to ready-for-review, I would appreciate some IRL testing with people's different IDE / editing experience to see if they run into re-builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the native (.cpp/.cu/.h/.metal) code for different HAL layers into its own crate [
risc0-sys]. This breaks some of the dependency links that trigger cargo rebuilds while editing different core crates in the tree and hopefully will increase development iteration speed.This also paves the way for using
cargo clippyas part of our development / CI pipeline.