Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rust 1.69.0 #553

Merged
merged 10 commits into from
May 10, 2023
Merged

Update to rust 1.69.0 #553

merged 10 commits into from
May 10, 2023

Conversation

mothran
Copy link
Contributor

@mothran mothran commented May 8, 2023

No description provided.

@mothran mothran requested review from flaub, shkoo and SchmErik May 8, 2023 23:57
@mothran
Remove alloc_error_handler feature
11a1352 
With rust 1.68 the alloc_error_handler was removed and now the OOM will
call the panic handler. Removed the handler and added a OOM test for the
guest
@mothran
Cargo fmt
3c9a665
@github-actions
Copy link

github-actions bot commented May 9, 2023

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default 73da75a

Click to hide benchmark
Test Base PR %
fib/100/execute 1433.2±2.98ms 1424.0±5.20ms -0.64%
fib/100/prove 5.8±0.06s 5.8±0.08s 0.00%
fib/100/total 7.3±0.09s 7.2±0.05s -1.37%
fib/1000/execute 1448.9±8.44ms 1433.4±5.05ms -1.07%
fib/1000/prove 5.9±0.06s 5.8±0.07s -1.69%
fib/1000/total 7.3±0.08s 7.3±0.06s 0.00%
fib/10000/execute 1604.4±27.28ms 1551.7±3.08ms -3.28%
fib/10000/prove 22.2±0.12s 22.1±0.13s -0.45%
fib/10000/total 23.8±0.19s 23.8±0.13s 0.00%

Benchmark for macOS-default 73da75a

Click to hide benchmark
Test Base PR %
fib/100/execute 685.4±1.44ms 685.1±1.35ms -0.04%
fib/100/prove 3.7±0.09s 3.7±0.07s 0.00%
fib/100/total 4.5±0.05s 4.5±0.06s 0.00%
fib/1000/execute 692.0±1.04ms 691.4±1.18ms -0.09%
fib/1000/prove 3.8±0.04s 3.8±0.05s 0.00%
fib/1000/total 4.5±0.04s 4.4±0.07s -2.22%
fib/10000/execute 755.3±1.56ms 748.2±2.62ms -0.94%
fib/10000/prove 15.3±0.08s 15.3±0.09s 0.00%
fib/10000/total 16.1±0.15s 16.1±0.08s 0.00%

Benchmark for macOS-metal 73da75a

Click to hide benchmark
Test Base PR %
fib/100/execute 685.3±0.85ms 685.3±1.43ms 0.00%
fib/100/prove 911.8±5.64ms 904.9±4.95ms -0.76%
fib/100/total 1626.1±8.51ms 1621.6±7.01ms -0.28%
fib/1000/execute 695.6±15.26ms 692.1±1.07ms -0.50%
fib/1000/prove 932.0±3.56ms 922.7±3.32ms -1.00%
fib/1000/total 1648.4±6.80ms 1646.1±7.54ms -0.14%
fib/10000/execute 754.5±1.13ms 746.4±0.83ms -1.07%
fib/10000/prove 3.4±0.01s 3.4±0.01s 0.00%
fib/10000/total 4.2±0.01s 4.1±0.01s -2.38%

@github-actions
Copy link

github-actions bot commented May 9, 2023

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 4809af8

Click to hide benchmark
Test Base PR %
fib/100/execute 686.3±1.57ms 685.8±1.21ms -0.07%
fib/100/prove 3.7±0.05s 3.7±0.06s 0.00%
fib/100/total 4.5±0.04s 4.4±0.05s -2.22%
fib/1000/execute 692.4±0.85ms 691.2±1.50ms -0.17%
fib/1000/prove 3.7±0.04s 3.7±0.06s 0.00%
fib/1000/total 4.5±0.06s 4.5±0.03s 0.00%
fib/10000/execute 755.8±1.81ms 747.5±1.27ms -1.10%
fib/10000/prove 15.4±0.14s 15.2±0.15s -1.30%
fib/10000/total 16.1±0.23s 16.0±0.09s -0.62%

Benchmark for macOS-metal 4809af8

Click to hide benchmark
Test Base PR %
fib/100/execute 685.8±0.72ms 685.2±1.07ms -0.09%
fib/100/prove 911.5±4.21ms 905.9±3.98ms -0.61%
fib/100/total 1633.0±9.37ms 1620.2±3.86ms -0.78%
fib/1000/execute 692.5±1.24ms 691.2±1.28ms -0.19%
fib/1000/prove 928.7±3.75ms 927.1±5.77ms -0.17%
fib/1000/total 1657.4±8.94ms 1648.9±5.73ms -0.51%
fib/10000/execute 754.6±0.94ms 746.7±1.48ms -1.05%
fib/10000/prove 3.4±0.01s 3.4±0.03s 0.00%
fib/10000/total 4.2±0.01s 4.1±0.01s -2.38%

@flaub flaub enabled auto-merge (squash) May 10, 2023 08:42
@github-actions
Copy link

Benchmark for Linux-cuda e2c43d8

Click to hide benchmark
Test Base PR %
fib/100/execute 332.5±30.93ms 303.8±5.25ms -8.63%
fib/100/prove 1424.1±40.08ms 1410.4±38.46ms -0.96%
fib/100/total 1927.6±231.75ms 1730.1±47.97ms -10.25%
fib/1000/execute 311.5±3.99ms 306.6±2.29ms -1.57%
fib/1000/prove 1648.9±206.42ms 1482.2±53.87ms -10.11%
fib/1000/total 1987.7±245.06ms 1766.9±43.82ms -11.11%
fib/10000/execute 413.9±4.95ms 402.4±2.95ms -2.78%
fib/10000/prove 4.4±0.12s 4.4±0.13s 0.00%
fib/10000/total 4.9±0.43s 4.8±0.12s -2.04%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default e2c43d8

Click to hide benchmark
Test Base PR %
fib/100/execute 701.0±7.50ms 686.1±1.45ms -2.13%
fib/100/prove 3.8±0.04s 3.7±0.04s -2.63%
fib/100/total 4.5±0.05s 4.4±0.05s -2.22%
fib/1000/execute 695.1±7.61ms 691.0±1.23ms -0.59%
fib/1000/prove 3.8±0.06s 3.8±0.05s 0.00%
fib/1000/total 4.5±0.07s 4.5±0.06s 0.00%
fib/10000/execute 753.8±1.19ms 747.1±1.56ms -0.89%
fib/10000/prove 15.3±0.16s 15.2±0.08s -0.65%
fib/10000/total 16.1±0.07s 16.1±0.11s 0.00%

Benchmark for macOS-metal e2c43d8

Click to hide benchmark
Test Base PR %
fib/100/execute 685.8±1.18ms 685.2±0.74ms -0.09%
fib/100/prove 916.1±6.27ms 906.7±3.72ms -1.03%
fib/100/total 1632.5±9.00ms 1619.5±7.61ms -0.80%
fib/1000/execute 691.7±1.37ms 690.6±1.38ms -0.16%
fib/1000/prove 930.2±3.99ms 923.3±3.54ms -0.74%
fib/1000/total 1652.6±9.21ms 1651.0±7.12ms -0.10%
fib/10000/execute 754.5±0.96ms 747.2±1.05ms -0.97%
fib/10000/prove 3.4±0.01s 3.4±0.01s 0.00%
fib/10000/total 4.2±0.01s 4.1±0.02s -2.38%

@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 1bd2c20

Click to hide benchmark
Test Base PR %
fib/100/execute 686.9±1.27ms 685.2±0.66ms -0.25%
fib/100/prove 3.7±0.05s 3.7±0.06s 0.00%
fib/100/total 4.4±0.08s 4.4±0.07s 0.00%
fib/1000/execute 692.6±1.06ms 691.0±0.64ms -0.23%
fib/1000/prove 3.8±0.04s 3.7±0.06s -2.63%
fib/1000/total 4.5±0.06s 4.4±0.06s -2.22%
fib/10000/execute 753.1±0.88ms 747.1±1.20ms -0.80%
fib/10000/prove 15.4±0.08s 15.2±0.06s -1.30%
fib/10000/total 16.1±0.10s 16.1±0.16s 0.00%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 937ebf2

Click to hide benchmark
Test Base PR %
fib/100/execute 704.6±1.45ms 685.8±1.31ms -2.67%
fib/100/prove 3.7±0.06s 3.7±0.07s 0.00%
fib/100/total 4.5±0.04s 4.4±0.08s -2.22%
fib/1000/execute 710.5±0.83ms 691.0±1.58ms -2.74%
fib/1000/prove 3.8±0.03s 3.7±0.07s -2.63%
fib/1000/total 4.5±0.04s 4.5±0.05s 0.00%
fib/10000/execute 757.1±4.42ms 747.7±2.30ms -1.24%
fib/10000/prove 15.4±0.11s 15.3±0.13s -0.65%
fib/10000/total 16.2±0.17s 16.1±0.15s -0.62%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@flaub flaub merged commit 364e3a6 into main May 10, 2023
12 checks passed
@flaub flaub deleted the parker/rust-1.69 branch May 10, 2023 23:16
@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default b8a5864

Click to hide benchmark
Test Base PR %
fib/100/execute 1425.9±4.56ms 1423.3±2.69ms -0.18%
fib/100/prove 5.8±0.04s 5.8±0.07s 0.00%
fib/100/total 7.2±0.08s 7.2±0.06s 0.00%
fib/1000/execute 1433.9±14.42ms 1429.9±4.08ms -0.28%
fib/1000/prove 5.9±0.07s 5.8±0.03s -1.69%
fib/1000/total 7.3±0.04s 7.3±0.04s 0.00%
fib/10000/execute 1569.2±5.74ms 1549.6±3.40ms -1.25%
fib/10000/prove 22.2±0.19s 22.0±0.11s -0.90%
fib/10000/total 23.7±0.17s 23.6±0.07s -0.42%

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal b8a5864

Click to hide benchmark
Test Base PR %
fib/100/execute 686.0±2.18ms 685.4±1.11ms -0.09%
fib/100/prove 911.2±4.26ms 897.4±4.31ms -1.51%
fib/100/total 1628.5±7.17ms 1618.1±6.83ms -0.64%
fib/1000/execute 691.9±0.99ms 690.8±1.63ms -0.16%
fib/1000/prove 930.8±3.98ms 917.0±5.43ms -1.48%
fib/1000/total 1655.3±5.55ms 1642.2±11.35ms -0.79%
fib/10000/execute 753.8±1.02ms 745.9±0.86ms -1.05%
fib/10000/prove 3.4±0.01s 3.4±0.01s 0.00%
fib/10000/total 4.2±0.01s 4.1±0.01s -2.38%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaub flaub flaub approved these changes

@SchmErik SchmErik SchmErik approved these changes

@shkoo shkoo Awaiting requested review from shkoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mothran @flaub @SchmErik @choongng