fix for ma_fetch test in rv32mi #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@aswaterman |
|
Hi Neel |
|
Disregard the previous request, I have merged from the master |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ma_fetch test has been written in a way that implementations with and without "C" support should generate the same signature. The aim is to avoid
at multiple places.
However, currently the signatures generated by implementation with and without C support are different. This is because the trap handler sets the return address in mepc to point to
instead of
This merge request fixes that and also updates the signature. Has been verified with e-class, riscvOVPsim and spike.