Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual is missing links for riscv instruction set documentation #23

Closed
Farmerjoe12 opened this issue Dec 8, 2018 · 3 comments
Closed

Comments

@Farmerjoe12
Copy link
Contributor

The manual has an Instruction Set section but under Instructions there is no link to the instruction set manual. Instead there is some placeholder text that mentions the instruction manual link could be added.

@Farmerjoe12
Copy link
Contributor Author

Farmerjoe12 commented Dec 8, 2018

I created a local branch with some links that I could find. I added the riscv specifications site, the draft repository and other links, and I'd like to create a new branch and pull request to merge the changes to master.

@jim-wilson
Copy link
Collaborator

You don't need permission to create a pull request. But maybe you are confused about the process?
Create a fork, create a branch in your fork, put your changes on that branch, commit, push, and then you can create a pull request for this tree using your branch in your fork.

This is documented in the github help which is accessible from the pull down menu in the upper right hand corner.
https://help.github.com/articles/creating-a-pull-request-from-a-fork/

@Farmerjoe12
Copy link
Contributor Author

Sorry, you’re right I’ve never forked a repo before so that is where I was confused. I’ll make a fork and follow the process you outlined, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants