Support per-device arguments and device factory reuse #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
requested changes
Apr 29, 2024
liuyu81
force-pushed
the
master
branch
2 times, most recently
from
fffff31
to
cebc2b7
Compare
As proposed in riscv-software-src#1652, we made the following changes to MMIO device (factory) plugin API, to mitigate current limitations and facilitate factory reuse. - removed `sargs` from `device_factory_t`, and introduced a new type alias `device_factory_sargs_t` to capture `<device_factory_t *, sargs>` pairs, this is used to instantiate sim_t instances; - changed the signature of `device_factory_t::generate_fdt` and `device_factory_t::parse_from_fdt` to take on an extra `sargs` argument, for instantiating devices with per-device arguments; - made `device_factory_t` const and potentially resuable across multiple `sim_t` instances.
jerryz123
approved these changes
Apr 30, 2024
|
Thanks for the review. I have marked the |
|
@jerryz123 I don't have time to review this right now, but feel free to merge if you think it's good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device arguments (or
sargs) is a new feature introduced in #1522. It allows passing extrasargsfrom CLI--device=factory[,sargs]option down to MMIO device plugins.While the use case is definitely sound, previous implementation does not really support instantiating multiple devices from the same factory with different sets of arguments. Another limitation (of previous implementation), is that -- due to the injection of per-device
sargsglobally intodevice_factory_t-- it prohibits device factory resue across multiplesim_tinstances.As proposed in #1652, we have created this PR to address the above limitations. The fix is three fold,
sargsfromdevice_factory_t, and introduced a new type aliasdevice_factory_sargs_tto capture <device_factory_t *,sargs> pairs, this is used to instantiatesim_tinstances;device_factory_t::generate_fdt/device_factory_t::parse_from_fdtto take on an extrasargsargument, for instantiating devices with per-device arguments;device_factory_tconst and potentially resuable across multiplesim_tinstances.