Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdb protocol fixes #83

Merged
merged 2 commits into from
Feb 7, 2017
Merged

Conversation

bacam
Copy link
Contributor

@bacam bacam commented Dec 21, 2016

These fix a couple of problems that don't seem to affect gdb, but can confuse other tools that attempt to use the gdb protocol. One fixes reading S0 with p8 (gdb uses g), and the other is a duplicate response, which gdb appears to ignore.

@timsifive
Copy link
Collaborator

I have the exact same comment as for your other pull request. The code looks right. Did you run the test suite?

Thank you,
Tim

@bacam
Copy link
Contributor Author

bacam commented Dec 21, 2016

Running the tests picks up issue #84, because the duplicate response is effectively hiding the error. It's probably best not to merge this without sorting that out first.

@timsifive
Copy link
Collaborator

What errors are you seeing? I just ran the testsuite against your branch and everything worked.

@bacam
Copy link
Contributor Author

bacam commented Dec 30, 2016

I get failures for SimpleS1Test and WriteGprs:

(gdb) p/x $s1=0xe520e31011238d8
p/x $s1=0xe520e31011238d8
Could not write register "x9"; remote failure reply 'E03'

and

(gdb) p/x $x9=478198855569
p/x $x9=478198855569
Could not write register "x9"; remote failure reply 'E03'

respectively. This is for 64 bit; I think 32 bit would work. If I also apply #85 then it works for 64 bit.

@bacam
Copy link
Contributor Author

bacam commented Feb 7, 2017

I just checked this against the current head, and the debug test suite passes on both 32 bit and 64 bit.

@timsifive timsifive merged commit daaf28f into riscv-software-src:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants