Only read exception flag in gdb register read/write. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag is 32 bits, and if we read 64/128 bits then we get fragments of S1 too and can accidentally send an error. Fixes riscv-software-src#84.
|
I've successfully run the 64 bit tests on this. |
Merged
|
Looks great! Thank you! Andrew, can I merge things like this or would you like to do it? |
|
I'll merge it while I'm here (but you should feel free to merge similar PRs). Thanks @bacam @timsifive |
aswaterman
pushed a commit
that referenced
this pull request
Jan 17, 2017
The flag is 32 bits, and if we read 64/128 bits then we get fragments of S1 too and can accidentally send an error. Fixes #84.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is 32 bits, and if we read 64/128 bits then we get fragments of
S1 too and can accidentally send an error. Fixes #84.