RISCV32 Fixes #267
Merged
RISCV32 Fixes #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khem Raj <raj.khem@gmail.com>
These recipes have gotten fixed overtime Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use -x jitter to fix the cpu hog Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
alistair23
reviewed
Feb 11, 2021
Comment on lines
-15
to
+17
| # EXTRA_IMAGEDEPENDS += "u-boot" | ||
| # UBOOT_MACHINE = "qemu-riscv32_smode_defconfig" | ||
| # UBOOT_ELF = "u-boot" | ||
| EXTRA_IMAGEDEPENDS += "u-boot" | ||
| UBOOT_MACHINE = "qemu-riscv32_smode_defconfig" | ||
| UBOOT_ELF = "u-boot" |
alistair23
reviewed
Feb 11, 2021
Comment on lines
+4
to
+11
| Subject: [PATCH] riscv32: Use double-float ABI for rv32 | ||
|
|
||
| So it can use libgcc built with OE toolchain | ||
| Fixes | ||
| error: "can't link hard-float modules with soft-float modules" | ||
|
|
||
| Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
| --- |
There was a problem hiding this comment.
Awesome!
Can this go upstream instead of here? Once the Linux-yocto build is working again I wanted to upstream RV32 support.
alistair23
reviewed
Feb 11, 2021
Comment on lines
+1
to
+2
| FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" | ||
|
|
There was a problem hiding this comment.
Can this go to OE-Core as well?
There was a problem hiding this comment.
perhaps yes but it should go along with the series to enable rv32, otherwise there will be questions as its purely rv32 patch
alistair23
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.